Codecov Report

Merging #59 into master will decrease coverage by 12.06%.
The diff coverage is 8.6%.

@@             Coverage Diff             @@
##           master      #59       +/-   ##
===========================================
- Coverage   91.37%   79.31%   -12.07%     
===========================================
  Files          12       13        +1     
  Lines         545      638       +93     
===========================================
+ Hits          498      506        +8     
- Misses         47      132       +85

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 660ef8b...14cfdd2. Read the comment docs.

Thanks for posting a PR! I will try to look at this fully later today.

One note, could you make a unit test for this new code.

Also I have never played in a FAAB league before but do you know if you can get this data through the recent_activity endpoint?

I'll work on those tests soon. And no you can't get the same info from recent activity, because in auction leagues you can see the failed bids. Because failed bids don't end up as an actual transaction they won't appear on the activity feed.

Very interesting! I will also try out that endpoint in my non FAAB league and see what else it returns.

I've actually been looking into including offers report into this module, and apparently everything I need has been here already!

I'm curious to know what needs to be worked on here to get this integrated/merged?

This PR was created before the package was refactored for multiple sports. This endpoint can be used for all league types to get wavier report.

I think we could do something similar to how baseball created different box_score categories depending on the league settings. So we could do the same for wavier report. Create a wavier report class and have it add different data depending on if the League is FABB or just normal wavier claims.